Suggest adding a semicolon to a closure without block #97371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This transforms `|| expr` into `|| { expr; }`.
rustbot
added
the
T-compiler
|
r? @oli-obk (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
ChayimFriedman2
commented
May 24, 2022
ChayimFriedman2
commented
May 24, 2022
ChayimFriedman2
commented
May 24, 2022
oli-obk
requested changes
May 30, 2022
| &self, | ||
| err: &mut Diagnostic, | ||
| expression: &'tcx hir::Expr<'tcx>, | ||
| expected: Ty<'tcx>, | ||
| needs_block: bool, |
There was a problem hiding this comment.
Not a fan of the bool argument, but I can't come up with anything clearer right now
There was a problem hiding this comment.
Neither am I :) Maybe an enum will do?
…`suggest_missing_semicolon()`
oli-obk
approved these changes
May 31, 2022
|
@bors r+ |
|
📌 Commit 6afaffb has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 31, 2022
Rollup of 6 pull requests Successful merges: - rust-lang#97089 (Improve settings theme display) - rust-lang#97229 (Document the current aliasing rules for `Box<T>`.) - rust-lang#97371 (Suggest adding a semicolon to a closure without block) - rust-lang#97455 (Stabilize `toowned_clone_into`) - rust-lang#97565 (Add doc alias `memset` to `write_bytes`) - rust-lang#97569 (Remove `memset` alias from `fill_with`.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This transforms
|| exprinto|| { expr; }.Closes #97359.